← Back to team overview

maria-developers team mailing list archive

Re: MDEV-25075: Ignorable index makes the resulting CREATE TABLE invalid

 

Hi Varun,

> diff --git a/sql/lex.h b/sql/lex.h
> index 542356c0e433..5a9ec2ec1b35 100644
> --- a/sql/lex.h
> +++ b/sql/lex.h
> @@ -289,6 +289,7 @@ static SYMBOL symbols[] = {
>    { "IDENTIFIED",	SYM(IDENTIFIED_SYM)},
>    { "IF",		SYM(IF_SYM)},
>    { "IGNORE",		SYM(IGNORE_SYM)},
> +  { "IGNORED",		SYM(IGNORED_SYM)},
>    { "IGNORE_DOMAIN_IDS", SYM(IGNORE_DOMAIN_IDS_SYM)},
>    { "IGNORE_SERVER_IDS", SYM(IGNORE_SERVER_IDS_SYM)},
>    { "IMMEDIATE",	SYM(IMMEDIATE_SYM)},

Above this array one can see:

>>   ...
>>   NOTE!!
>>   If you add or delete symbols from this file, you must also update results for
>>   the perfschema.start_server_low_digest_sql_length test!
>> */
>>
>> static SYMBOL symbols[] = {

and indeed the buildbot shows failures, e.g.

http://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos74-amd64/builds/18485/steps/mtr/logs/stdio

CURRENT_TEST: perfschema.start_server_low_digest_sql_length
--- /usr/share/mysql-test/suite/perfschema/r/start_server_low_digest_sql_length.result	2021-03-10 06:23:20.000000000 +0000
+++ /dev/shm/var/4/log/start_server_low_digest_sql_length.reject	2021-03-10 07:37:16.351213429 +0000
@@ -8,5 +8,5 @@
 ####################################
 SELECT event_name, digest, digest_text, sql_text FROM events_statements_history_long;
 event_name	digest	digest_text	sql_text
-statement/sql/select	beb5bd93b7e8c45bc5cb6060804988e8	SELECT ? + ? + 	SELECT ...
-statement/sql/truncate	faf6cefb662b443f05e97b5c5ab14a59	TRUNCATE TABLE 	truncat...
+statement/sql/select	ade774bdfbc132a71810ede8ef469660	SELECT ? + ? + 	SELECT ...
+statement/sql/truncate	0f84807fb4a75d0f391f8a93e7c3c182	TRUNCATE TABLE 	truncat...

Please fix this.

BR
 Sergei
-- 
Sergei Petrunia, Software Developer
MariaDB Corporation | Skype: sergefp | Blog: http://petrunia.net




Follow ups