← Back to team overview

maria-developers team mailing list archive

Re: dbb62d20f36: Fixes that enables my_new.cc (new wrapper using my_malloc)



On Sun, Mar 28, 2021 at 11:18 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
> Hi, Monty!


> Here's a simplified patch that works (I've applied it, compiled, run
> the test suite, and verified in a debugger that new() from my_new.cc is
> used):

One which systems did you test it?

Also on older systems that does not provide <new> ?

Please always provide a diff on top of my diff, so that I can see what
changes you propose,
or comment inline what you want to change.
I did not find the diff you provide usable (without too much work on
my side comparing diffs.

Anyway, I do feel my version is safer as it takes into account if
HAVE_CXX_NEW exists or not,
so I will stick with it.