maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Andrei!

On Apr 07, Andrei Elkin wrote:
> Sergei, salve.
> 
> I should've asked for clarification to
> 
> >>> +          }
> >>> +        } else
> >>
> >> add into the else branch something like
> >>
> >>   /* this branch is only for the legacy TC_LOG_MMAP */
> >>   compile_time_assert(sizeof(TC_LOG_MMAP) > 1 );
> >
> > [x]
> 
> Actually the branch, which is
> 
>         } else
>         if (IF_WSREP((wsrep_emulate_bin_log &&
>                       wsrep_is_wsrep_xid(info->list + i) &&
>                       x <= wsrep_limit), false) ||
>             (info->commit_list ?
>              my_hash_search(info->commit_list, (uchar *)&x, sizeof(x)) != 0 :
>              tc_heuristic_recover == TC_HEURISTIC_RECOVER_COMMIT))
>         {
> #ifndef DBUG_OFF
>           int rc=
> #endif
>             hton->commit_by_xid(hton, info->list+i);
> 
> deals with tc_heuristic_recover.
> 
> I am not sure what you meant.

I wanted to make sure all TC_LOG_MMAP code is removed when TC_LOG_MMAP
itself goes away. But apparenlty I overlooked the heuristic recover
path.

So this code deals with both heuristic recover and TC_LOG_MMAP.
Okay than, forget that comment.

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx