← Back to team overview

maria-developers team mailing list archive

Re: 32c73138ff4: Remove some usage of Check_level_instant_set and Sql_mode_save


Hi, Monty!

On Apr 19, Michael Widenius wrote:
> revision-id: 32c73138ff4 (mariadb-10.5.2-559-g32c73138ff4)
> parent(s): 07708eb9b28
> author: Michael Widenius <michael.widenius@xxxxxxxxx>
> committer: Michael Widenius <michael.widenius@xxxxxxxxx>
> timestamp: 2021-03-25 12:06:34 +0200
> message:
> Remove some usage of Check_level_instant_set and Sql_mode_save
> The reason for the removal are:
> - Generates more code
>   - Storing and retreving THD
>   - Causes extra code and daata to be generated to handle possible throw
>     exceptions (which never happens in MariaDB code)
> - Uses more stack space

No, Monty.
We've discussed it already, this makes code more complex, fragile and
bug prone.

And it does *not* generates extra code or data or stack - before writing
this email I've compiled mariadbd both ways and compared the generated
code for the function in question, it was *identical*.

> Other things:

> - Changed convert_const_to_int() to use item->save_in_field_no_warnings(),
>   which made the code shorter and simpler.
> - Added thd as argument to store_key.copy() to make function simpler
> - Added thd as argument to some subselect* constructor that inherites
>   from Item_subselect.

these changes are good, thanks

VP of MariaDB Server Engineering
and security@xxxxxxxxxxx

Follow ups