maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Aleksey!

On Jun 02, Aleksey Midenkov wrote:
> revision-id: 8e79d168614 (mariadb-10.2.31-989-g8e79d168614)
> parent(s): 433dd490d33
> author: Aleksey Midenkov <midenok@xxxxxxxxx>
> committer: Aleksey Midenkov <midenok@xxxxxxxxx>
> timestamp: 2021-05-31 16:20:38 +0300
> message:
> 
> MDEV-25672 table alias from previous statement interferes later commands.

I'm sorry. I don't understand what all this new code for.

To make sure that vcol's field->table_name is refreshed for every statement?
What is vcol's field->table_name used for besides your CREATE TABLE check?

If it's not used for anything then a much simpler fix would be narrow
the check - it only needs to be run for new vcols in CREATE TABLE,
disabling it for old vcols in ALTER TABLE will do the trick. Like

-    if (p.table_name.length && table_name)
+    if (!field && p.table_name.length && table_name)

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx