← Back to team overview

maria-developers team mailing list archive

Re: 2f9bbf392072: MDEV-18734 optimization by taking ownership via String::swap()


Hi Sergei!

Do you plan to fix everything you just said and push yourself or let
me push it as is? Btw, there were many allocations over one loop:
that's why I used mem_root. multi_malloc() won't do the job there.
That could be done either with explicit moving pointer or some utility
class holding such pointer. I decided to upgrade mem_root for such
pattern so it could do the double job and we had a cleaner code.

On Thu, Jun 3, 2021 at 2:00 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
> Hi, Aleksey!
> I think it's better to wrap it up quickly, agree on changes and push the
> fix before the next release.
> On Jun 01, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > Users could benefit from this fix of MDEV-18734 since the last
> > changes. Do you really think the open questions left are so important
> > for this bug to be still not pushed?
> >
> Regards,
> Sergei
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx

All the best,

Aleksey Midenkov

Follow ups