maria-developers team mailing list archive

[Aleksey Midenkov <midenok@xxxxxxxxx>]

Hi Sergei!

Really, this is not pure refactoring. I've been planning to remove it
if it will not be useful for MDEV-22165 (that task should be based on
this branch). Meanwhile, can you please review other commits?


On Mon, Aug 23, 2021 at 7:35 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
>
> Hi, Aleksey!
>
> On Aug 23, Aleksey Midenkov wrote:
> > revision-id: f14cfd22115 (mariadb-10.6.1-63-gf14cfd22115)
> > parent(s): 03225474d60
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
> > timestamp: 2021-08-17 20:01:48 +0300
> > message:
> >
> > Vanilla refactoring: binlog query in DDL_LOG_RENAME_ACTION
> >
> > This turned out to be not needed for MDEV-22166. But it still might be
> > useful for MDEV-22165 or later.
>
> There are three changes here.
> Adding 'locked' to ddl_log_store_query, creating
> st_ddl_recovery::binlog_query(), adding 'case RENAME_PHASE_BINLOG'
>
> st_ddl_recovery::binlog_query() is ok, if you want to keep it.
> But the other two aren't a refactoring, it's creating new functionality
> which isn't used in this patch, dead code basically. And your commit
> comment seems to imply that this new functionality isn't needed
> in the following feature patch either.
>
> While your other refactoring patches are indeed pure refactoring, this
> one isn't, so, please, remove it from the patchset if it isn't used
> there. You can keep st_ddl_recovery::binlog_query() if you'd like - it
> is indeed pure refactoring.
>
> Regards,
> Sergei
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx



-- 
All the best,

Aleksey Midenkov
@midenok