maria-developers team mailing list archive

Thread
Date

Re: 2f812e800c0: MDEV-22447: SIGSEGV in Item::val_uint on EXPLAIN

To: Oleksandr Byelkin <sanja@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 15 Oct 2021 15:41:55 +0200
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <hsgylh9yf8K.A.16C.KTYahB@pweza>

Hi, Oleksandr!

On Oct 15, Oleksandr Byelkin wrote:
> revision-id: 2f812e800c0 (mariadb-10.2.40-57-g2f812e800c0)
> parent(s): 696de6d06c0
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2021-09-16 14:12:48 +0200
> message:
> 
> MDEV-22447: SIGSEGV in Item::val_uint on EXPLAIN
> 
> take into account possible NULL
> 
> diff --git a/sql/sql_select.cc b/sql/sql_select.cc
> index ff584e936b7..d1b738e94a0 100644
> --- a/sql/sql_select.cc
> +++ b/sql/sql_select.cc
> @@ -389,7 +389,7 @@ bool handle_select(THD *thd, LEX *lex, select_result *result,
>                          ER_QUERY_EXCEEDED_ROWS_EXAMINED_LIMIT,
>                          ER_THD(thd, ER_QUERY_EXCEEDED_ROWS_EXAMINED_LIMIT),
>                          thd->accessed_rows_and_keys,
> -                        thd->lex->limit_rows_examined->val_uint());
> +                        thd->lex->get_limit_rows_examined());
>      thd->abort_on_warning= saved_abort_on_warning;
>      thd->reset_killed();
>    }

How comes, it gets into ER_QUERY_EXCEEDED_ROWS_EXAMINED_LIMIT
if limit_rows_examined is NULL?

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx