maria-developers team mailing list archive

Thread
Date

Re: 351a0a7d6b7: MDEV-26841: ROW_NUMBER is not set and differs from the message upon ER_WRONG_VALUE_COUNT_ON_ROW for the 1st row

To: Rucha Deodhar <rucha.deodhar@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Sun, 17 Oct 2021 16:21:25 +0200
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <zjeOoAwNt4P.A.AfF.7EDbhB@pweza>

Hi, Rucha!

On Oct 17, Rucha Deodhar wrote:
> revision-id: 351a0a7d6b7 (mariadb-10.6.1-138-g351a0a7d6b7)
> parent(s): c27f04ede5a
> author: Rucha Deodhar
> committer: Rucha Deodhar
> timestamp: 2021-10-17 16:24:47 +0530
> message:
> 
> MDEV-26841: ROW_NUMBER is not set and differs from the message upon
> ER_WRONG_VALUE_COUNT_ON_ROW for the 1st row
> 
> diff --git a/sql/sql_insert.cc b/sql/sql_insert.cc
> index 3dff6722a3d..9e81c33ff8f 100644
> --- a/sql/sql_insert.cc
> +++ b/sql/sql_insert.cc
> @@ -229,6 +229,8 @@ static int check_insert_fields(THD *thd, TABLE_LIST *table_list,
>      }
>      if (values.elements != table->s->visible_fields)
>      {
> +      if (values.elements > table->s->visible_fields)

why do you need an if() here?

> +        thd->get_stmt_da()->inc_current_row_for_warning();
>        my_error(ER_WRONG_VALUE_COUNT_ON_ROW, MYF(0), 1L);
>        DBUG_RETURN(-1);
>      }
Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx