maria-developers team mailing list archive

[Daniel Black <daniel@xxxxxxxxxxx>]

Manohar,

Thank you very much for your contribution.

This isn't an area of code I'm particularly familiar with however I'll
find someone who is.

Is this code really only applicable in ORACLE mode? I think its ok if
it isn't the syntax doesn't conflict with non-oracle mode, provide the
default is sp_variable::MODE_IN.

What would significantly help is writing a test case. Enough to
demonstrate the OUT / INOUT portions of the code, and that the error
is generated when incorrectly called.

Create a new file like mysql-test/suite/compat/oracle/t/ps.test (or
mysql-test/main/function.test) that creates functions, calls them in a
way that their results can be observed and the behaviour recorded.

Use --error ER_SF_OUT_INOUT_ARG_NOT_ALLOWED before the SQL statements
that generate errors.

Use mtr --record {file} to record the result file, check its contents
is what is expected.

Append and force push to the same branch. Rebase to 10.7 latest if you
are comfortable.


On Tue, Nov 2, 2021 at 11:59 AM Manohar K B <manohar.kb@xxxxxxxxx> wrote:
>
> Hi All,
>
> Good day.
>
>
>
> I have fixed ticket MDEV-10654 and raised PR.
>
> Can someone kindly review it?
>
>
>
> This is the first time I am contributing to MariaDB,
>
> so please guide me if I missed anything.
>
>
>
> Best regards,
>
> Manohar.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~maria-developers
> Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~maria-developers
> More help   : https://help.launchpad.net/ListHelp