maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Vladislav!

few questions below:

On Nov 18, Vladislav Vaintroub wrote:
> revision-id: c80991c79f7 (mariadb-10.6.1-213-gc80991c79f7)
> parent(s): cee33f1ab7c
> author: Vladislav Vaintroub
> committer: Vladislav Vaintroub
> timestamp: 2021-11-09 02:04:22 +0100
> message:
> 
> MDEV-25785 Add support for OpenSSL 3.0
> 
> Summary of changes
> 
> - MD_CTX_SIZE is increased
> 
> - EVP_CIPHER_CTX_buf_noconst(ctx) does not work anymore, points
>   to nobody knows where. The assumption made previously was that
>   (since the function does not seem to be documented)
>   was that it points to the last partial source block.
>   Add own partial block buffer for NOPAD encryption instead
> 
> - SECLEVEL in CipherString in openssl.cnf
>   had been downgraded to 0, from 1, to make TLSv1.0 and TLSv1.1 possible

The definition of SECLEVEL is:
Level 0

    Everything is permitted. This retains compatibility with previous
    versions of OpenSSL.

Level 1

    The security level corresponds to a minimum of 80 bits of security.
    Any parameters offering below 80 bits of security are excluded. As a
    result RSA, DSA and DH keys shorter than 1024 bits and ECC keys
    shorter than 160 bits are prohibited. All export cipher suites are
    prohibited since they all offer less than 80 bits of security. SSL
    version 2 is prohibited. Any cipher suite using MD5 for the MAC is
    also prohibited. Note that signatures using SHA1 and MD5 are also
    forbidden at this level as they have less than 80 security bits.

Only at level 3 does it say "TLS versions below 1.1 are not permitted."

I don't see why you had to change from 1 to 0. Do we have "signatures
using SHA1 and MD5"?

> - ctx_buf buffer now must be aligned to 16 bytes with openssl(
>   previously with WolfSSL only), ot crashes will happen
> 
> - updated aes-t , to be better debuggable
>   using function, rather than a huge multiline macro
>   added test that does "nopad" encryption piece-wise, to test
>   replacement of EVP_CIPHER_CTX_buf_noconst
> 
> diff --git a/cmake/ssl.cmake b/cmake/ssl.cmake
> index 7c2488be8bd..64c93ff9b4f 100644
> --- a/cmake/ssl.cmake
> +++ b/cmake/ssl.cmake
> @@ -139,9 +139,20 @@ MACRO (MYSQL_CHECK_SSL)
>        SET(SSL_INTERNAL_INCLUDE_DIRS "")
>        SET(SSL_DEFINES "-DHAVE_OPENSSL")
>  
> +      FOREACH(x INCLUDES LIBRARIES DEFINITIONS)
> +        SET(SAVE_CMAKE_REQUIRED_${x} ${CMAKE_REQUIRED_${x}})
> +      ENDFOREACH()

why do you set/restore them?

> +      # Silence "deprecated in OpenSSL 3.0"
> +      IF((NOT OPENSSL_VERSION) # 3.0 not determined by older cmake
> +         OR NOT(OPENSSL_VERSION VERSION_LESS "3.0.0"))
> +        SET(SSL_DEFINES "${SSL_DEFINES} -DOPENSSL_API_COMPAT=0x10100000L")
> +        SET(CMAKE_REQUIRED_DEFINITIONS -DOPENSSL_API_COMPAT=0x10100000L)
> +      ENDIF()

This is just postponing the inevitable.
They'll drop the old API eventually. As far as I understand the
internals were changed in a way that doesn't fit the old API.

Is there some safe subset of OpenSSL API that works both in 1.0 and in
3.0 ? It might be more future proof to use only that.

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx