maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Nikita!

On Nov 24, Nikita Malyavin wrote:
> >> > diff --git a/sql/sql_table.cc b/sql/sql_table.cc
> >> > index 29d0f487303..87dbe226c2e 100644
> >> > --- a/sql/sql_table.cc
> >> > +++ b/sql/sql_table.cc
> >> > @@ -11300,6 +11300,9 @@ static int online_alter_read_from_binlog(THD *thd, rpl_group_info *rgi,
> >> >
> >> >    IO_CACHE *log_file= log->flip();
> >> >
> >> > +  thd_progress_report(thd, 0, my_b_write_tell(log_file)
> >> > +                             / rgi->tables_to_lock->m_conv_table->s->reclength);
> >>
> >> 1. why do you do this "/ rgi->...->s->reclength" ?
> >
> > The idea was to write an approximate number of rows. I think it can
> > come in handy.
> >
> Well, I notice now that progress is in percents. I wonder if there's a
> way to get a raw value for a user.

I thought it's always in percents, that's why I wondered why you divided
the value by a constant :)

> > Should start from zero again.. I dont't see the stage change there, maybe
> > I wasn't sure should it be another stage or the same one.
> 
> Added in the new commit

Okay, good. You cannot have a progress going from 0% to 100% and then
again fron 0% to 100% all in the same stage, that's not what users
expect from a progress meter.

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx