maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Aleksey!

ok to push.
see one comment below.

On Jan 13, Aleksey Midenkov wrote:
> revision-id: 8f8e7ad5c80 (mariadb-10.3.31-80-g8f8e7ad5c80)
> parent(s): 88f8aa20bba
> author: Aleksey Midenkov
> committer: Aleksey Midenkov
> timestamp: 2022-01-12 21:47:03 +0300
> message:
> 
> MDEV-27217 DELETE partition selection doesn't work for history partitions
> 
> LIMIT history switching requires the number of history partitions to
> be marked for read: from first to last non-empty plus one empty. The
> least we can do is to fail with error message if the needed partition
> was not marked for read. As this is handler interface we require new
> handler error code to display user-friendly error message.
> 
> diff --git a/sql/ha_partition.cc b/sql/ha_partition.cc
> index bd73642cd0d..2f945f29ed1 100644
> --- a/sql/ha_partition.cc
> +++ b/sql/ha_partition.cc
> @@ -9872,6 +9874,11 @@ void ha_partition::print_error(int error, myf errflag)
>      m_part_info->print_no_partition_found(table, errflag);
>      DBUG_VOID_RETURN;
>    }
> +  else if (error == HA_ERR_PARTITION_LIST)
> +  {
> +    handler::print_error(error, errflag);
> +    DBUG_VOID_RETURN;
> +  }

this seems to be redundant, the else branch at the end covers it.

>    else if (error == HA_ERR_ROW_IN_WRONG_PARTITION)
>    {

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx