maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Rucha,

On Mar 02, Rucha Deodhar wrote:
> revision-id: 5d8838a79d5 (mariadb-10.6.1-352-g5d8838a79d5)
> parent(s): f8b3c661231
> author: Rucha Deodhar
> committer: Rucha Deodhar
> timestamp: 2022-02-15 22:29:54 +0530
> message:
> 
> MDEV-24920: Merge "old" SQL variable to "old_mode" sql variable
> 
> Analysis: There are 2 server variables- "old_mode" and "old". "old" is no
> longer needed as "old_mode" has replaced it (however still used in some places
>  in the code). "old_mode" and "old" has same purpose- emulate behavior from
> previous MariaDB versions. So they can be merged to avoid confusion.
> Fix: Deprecate "old" variable and create another mode for @@old_mode to mimic
> behavior of previous "old" variable. Create specific modes for specifix task
> that --old sql variable was doing earlier and use the new modes instead.
> 
> diff --git a/mysql-test/main/mysqld--help.result b/mysql-test/main/mysqld--help.result
> index 7cbfa52b846..261dbe2ffe0 100644
> --- a/mysql-test/main/mysqld--help.result
> +++ b/mysql-test/main/mysqld--help.result
> @@ -683,7 +683,8 @@ The following specify which files/extra groups are read (specified before remain
>   --old-mode=name     Used to emulate old behavior from earlier MariaDB or
>   MySQL versions. Any combination of: 
>   NO_DUP_KEY_WARNINGS_WITH_IGNORE, NO_PROGRESS_INFO, 
> - ZERO_DATE_TIME_CAST, UTF8_IS_UTF8MB3
> + ZERO_DATE_TIME_CAST, UTF8_IS_UTF8MB3, 
> + INDEX_HINT_MASK_JOIN, CHECKSUM_SLOW_NULLS

I'm sorry, I still cannot understand what these new modes do :(

I know that it was my idea to use "CHECKSUM_SLOW_NULLS", but now I'm,
like, "what does it mean?". Let's discuss it on slack

INDEX_HINT_MASK_JOIN - this seems to be easier, what about
INGORE_INDEX_ONLY_FOR_JOIN ? That's a bit long, but shorter than
NO_DUP_KEY_WARNINGS_WITH_IGNORE.

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx