maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Oleksandr,

On Sep 26, Oleksandr Byelkin wrote:
> > >    LEX_STRING name; /* name for named prepared statements */
> > >    LEX *lex;                                     // parse tree descriptor
> > > +  ulonglong ms_prepare_time; // time of preparation in microseconds
> >
> > "ms" here too :(
> > Better just say
> >
> >     my_hrtime_t prepare_time;
> 
> I changed everywhere to hr_

Yes, but you kept them ulonglong and not my_hrtime_t, why?
my_hrtime_t is a type for storing high resolution time values.

> > > +    timestamp.second_part= trigger->ms_create_time % 1000000;
> >
> > hrtime_to_time() and hrtime_sec_part()
> 
> they made for events, so I made hr_time_to_time, hr_time_from_time

What do you mean by "made for events" ?

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx