maria-developers team mailing list archive

Thread
Date

Re: 6ff49e48e4f: MDEV-26161: fix of view protocol

To: Oleksandr Byelkin <sanja@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 6 Jan 2023 12:50:50 +0100
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <R2J2Gby7OGO.A.HeF.ykAujB@pweza>

Hi, Oleksandr,

On Jan 06, Oleksandr Byelkin wrote:
> revision-id: 6ff49e48e4f (mariadb-10.3.37-54-g6ff49e48e4f)
> parent(s): 92ff948d021
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-12-06 10:22:06 +0100
> message:
> 
> MDEV-26161: fix of view protocol

could you please amend the commit comment to explain why
the statement produces a different error in a view protocol?

> diff --git a/mysql-test/main/gis.result b/mysql-test/main/gis.result
> index 358be520b06..37613bc71a0 100644
> --- a/mysql-test/main/gis.result
> +++ b/mysql-test/main/gis.result
> @@ -4980,11 +4980,11 @@ ERROR HY000: Illegal parameter data type geometry for operation 'is_used_lock'
>  # MDEV-26161 crash in Gis_point::calculate_haversine
>  #
>  select st_distance_sphere(x'01030000000400000004000000000000', multipoint(point(124,204)), 10);
> -ERROR 22003: Cannot get geometry object from data you send to the GEOMETRY field
> +Got one of the listed errors
>  select st_distance_sphere(x'010300000004000000040000', multipoint(point(124,204)), 10);
> -ERROR 22003: Cannot get geometry object from data you send to the GEOMETRY field
> +Got one of the listed errors
>  select st_distance_sphere(x'010300000001000000040000', multipoint(point(124,204)), 10);
> -ERROR 22003: Cannot get geometry object from data you send to the GEOMETRY field
> +Got one of the listed errors
>  #
>  # End of 10.3 tests
>  #
> diff --git a/mysql-test/main/gis.test b/mysql-test/main/gis.test
> index 716fab9bfeb..07b207dcdc9 100644
> --- a/mysql-test/main/gis.test
> +++ b/mysql-test/main/gis.test
> @@ -3093,11 +3093,11 @@ SELECT IS_USED_LOCK(POINT(1,1));
>  --echo #
>  --echo # MDEV-26161 crash in Gis_point::calculate_haversine
>  --echo #
> ---error ER_CANT_CREATE_GEOMETRY_OBJECT
> +--error ER_CANT_CREATE_GEOMETRY_OBJECT,ER_INTERNAL_ERROR
>  select st_distance_sphere(x'01030000000400000004000000000000', multipoint(point(124,204)), 10);
> ---error ER_CANT_CREATE_GEOMETRY_OBJECT
> +--error ER_CANT_CREATE_GEOMETRY_OBJECT,ER_INTERNAL_ERROR
>  select st_distance_sphere(x'010300000004000000040000', multipoint(point(124,204)), 10);
> ---error ER_CANT_CREATE_GEOMETRY_OBJECT
> +--error ER_CANT_CREATE_GEOMETRY_OBJECT,ER_INTERNAL_ERROR
>  select st_distance_sphere(x'010300000001000000040000', multipoint(point(124,204)), 10);
>  
>  --echo #
> 
Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx