maria-developers team mailing list archive

[Nikita Malyavin <nikitamalyavin@xxxxxxxxx>]

Hello Sergei!

I think I've found a way that will satisfy both of us, and will also close
my claim regarding the need for assertion.
See commit 0bcbec79
<https://github.com/MariaDB/server/commit/0bcbec79cf73c04f758bfb2c80d67c0f72ed1257>
.

Comparing htons seems to work also for REORGANIZE PARTITION, and will allow
making changes from
handler clones!

On Sun, 28 May 2023 at 12:36, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:

> Hi, Nikita,
>
> See, e.g. handler::is_clustering_key() or handler::ha_rnd_pos_by_record()
>
> On May 28, Nikita Malyavin wrote:
> > On Wed, 24 May 2023 at 18:32, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
> >
> > > > +bool handler::is_root_handler() const
> > > > +{
> > > > +  return this == table->file;
> > > > +}
> > >
> > > better make it inline in handler.h
> > >
> > > Can't 😓
> > TABLE is incomplete in handler.h.
> >
> Regards,
> Sergei
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx
>


-- 
Yours truly,
Nikita Malyavin