maria-discuss team mailing list archive

[Reindl Harald <h.reindl@xxxxxxxxxxxxx>]

Am 18.09.2013 19:07, schrieb Reindl Harald:
> Am 18.09.2013 18:35, schrieb Sergei Golubchik:
>> Anyway, jemalloc is bundled with the mariadb sources and is linked in
>> statically:
>>
>> $ ldd sql/mysqld|grep jemalloc
>> $ grep jemalloc sql/mysqld
>> Binary file sql/mysqld matches
> 
> oh no - please no static libraries that is a very bad style
> and explicitly forbidden by most distributions and patched
> around whereever upstreams insists on it
> 
> so we really need soemthing like
> 
>  -DWITH_SSL=system \
>  -DWITH_ZLIB=system \
> 
> or if it exists a more recent online manual because i often
> enough find things referring to ./configure and not cmake
> while figure it out from the source tree is not that nice for
> web-developers like which are good in rpm-building but not
> in C/C++ sources and make-scripts

don't get me wrong - but that is a joke

looking at the commented line there was even a "-DWITH_JEMALLOC=system"
planned and later dropped - that is not how linux systems should work

if there is a security bug in whatever bundeled library and the distribution
is pushing a update mariadb will still use the vulnerable version and that
is why linux-distributions would use "-DWITH_JEMALLOC=no" if they can't
patch around this upstream bug to not violate packaging guidelines

the solution is support "-DWITH_JEMALLOC=system" and if it does not work with
"jemalloc-3.4.0" this is a bug because dbmail and Apache Trafficserver are doing
________________________________________

SET(WITH_JEMALLOC "yes" CACHE STRING
    "Which jemalloc to use (possible values are 'no', 'bundled', 'yes' (same as bundled)")
#"Which jemalloc to use (possible values are 'no', 'bundled', 'system', 'yes' (system if possible, otherwise bundled)")

MACRO (CHECK_JEMALLOC)
  IF(WIN32)
    SET(WITH_JEMALLOC "no")
  ENDIF()
  IF(WITH_JEMALLOC STREQUAL "bundled" OR WITH_JEMALLOC STREQUAL "yes")
    USE_BUNDLED_JEMALLOC()
  ENDIF()
ENDMACRO()

Attachment: signature.asc
Description: OpenPGP digital signature