← Back to team overview

maria-discuss team mailing list archive

Re: what about cleanly deprecation of config options

 



Am 20.01.2017 um 17:11 schrieb Sergei Golubchik:
Hi, Reindl!

On Jan 20, Reindl Harald wrote:
what about spit some warnings in 10.0.x releases instead after update to
10.1.x service not starting and you can look what confdig options needs
to be removed

2017-01-20 16:34:36 140555676232000 [ERROR] /usr/libexec/mysqld: unknown
option '--skip-federated'
2017-01-20 16:34:36 140555676232000 [ERROR] Aborting

I think you have built your 10.0.x releases with federated and you've
built your 10.1.x without federated. That's why --skip-federated worked
in your 10.0 build and didn't work in your 10.1 build.

not by intention

If you'd like you can paste here exact commands you've used to build
10.0 and 10.1 and I'll see why federated isn't built anymore

it was never supposed to be built - frankly i would prefer if i could say "i only need xtradb and myisam, period" at configure

however, the "oh i don't understand a single config line and refuse to start" behavior is annoying for a decade now

at least it could support a param at startup to turn such errors to warning which means "i read my logs and fix it but while the service is up and running"
____________________________

the CMAKE call is unchanged and only that two params added to get rid of additional stuff with 10.1.x

 -DWITH_INNODB_DISALLOW_WRITES=OFF \
 -DWITH_WSREP=OFF \
____________________________

cmake . -DBUILD_CONFIG=mysql_release \
 -DFEATURE_SET="community" \
 -DCMAKE_INSTALL_PREFIX="%{_prefix}" \
 -DINSTALL_INCLUDEDIR=include/mysql \
 -DINSTALL_LAYOUT=RPM \
 -DINSTALL_LIBDIR="%{_lib}/mysql" \
 -DINSTALL_MANDIR=share/man \
 -DINSTALL_MYSQLSHAREDIR=share/mysql \
 -DINSTALL_MYSQLTESTDIR=share/mysql-test \
 -DINSTALL_PLUGINDIR="%{_lib}/mysql/plugin" \
 -DINSTALL_SBINDIR=libexec \
 -DINSTALL_SCRIPTDIR=bin \
 -DINSTALL_SQLBENCHDIR= \
 -DINSTALL_SUPPORTFILESDIR=share/mysql \
 -DMYSQL_DATADIR="%{_sharedstatedir}/mysql" \
 -DMYSQL_UNIX_ADDR="%{_sharedstatedir}/mysql/mysql.sock" \
 -DWITH_XTRADB=1 \
 -DWITH_PARTITION=1 \
 -DWITHOUT_ARCHIVE=1 \
 -DWITHOUT_BLACKHOLE=1 \
 -DWITHOUT_CASSANDRA=1 \
 -DWITHOUT_MROONGA=1 \
 -DWITHOUT_OQGRAPH=1 \
 -DWITHOUT_PERFSCHEMA=1 \
 -DWITHOUT_SPHINX=1 \
 -DWITHOUT_SPIDER=1 \
 -DENABLED_PROFILING=OFF \
 -DENABLE_DTRACE=OFF \
 -DENABLE_DEBUG_SYNC=OFF \
 -DWITHOUT_TOKUDB=ON \
 -DWITH_VALGRIND=OFF \
 -DWITH_SAFEMALLOC=OFF \
 -DWITH_EMBEDDED_SERVER=OFF \
 -DWITH_FEEDBACK=OFF \
 -DWITH_INNODB_DISALLOW_WRITES=OFF \
 -DWITH_LIBWRAP=OFF \
 -DWITH_READLINE=OFF \
 -DWITH_WSREP=OFF \
 -DUSE_NEW_READLINE_INTERFACE=ON \
 -DENABLED_LOCAL_INFILE=ON \
 -DNOT_FOR_DISTRIBUTION=ON \
 -DWITH_ATOMIC_OPS=smp \
 -DWITHOUT_DYNAMIC_PLUGINS=ON \
 -DWITH_PIC=ON \
 -DWITH_JEMALLOC=system \
 -DWITH_SSL=system \
 -DWITH_ZLIB=system


Follow ups

References