maria-discuss team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Reindl!

On Mar 16, Reindl Harald wrote:
> 
> 
> Am 16.03.2017 um 00:21 schrieb Sergei Golubchik:
> > Hi, Reindl!
> >
> > On Mar 15, Reindl Harald wrote:
> >>>>>
> >>>>> if it only would build any longer...............
> >>>>
> >>>> /home/builduser/rpmbuild/BUILD/mariadb-10.1.22/include/my_sys.h:649:43:
> >>>> error: unknown type name 'PSI_file_key'
> >>>>   extern int my_handler_delete_with_symlink(PSI_file_key key, const char *name,
> >>>
> >>> Sorry. I'm fixing it.
> >>
> >> will follow a 10.1.23 release shortly or can we have at least a unified
> >> difdf which can be applied by rpmbuild?
> >
> > This is the commit I've pushed:
> > https://github.com/mariadb/server/commit/2c2bd8c1556b081fccd0fc3e010dc3ea2c38fffb
> >
> > I don't think there will be a new release shortly... :(
> 
> how do i get that to a unified diff so it can be used in rpmbuilds %prep 
> section?
> 
> %patch1 -p1

https://github.com/mariadb/server/commit/2c2bd8c1556b081fccd0fc3e010dc3ea2c38fffb.diff
or
https://github.com/mariadb/server/commit/2c2bd8c1556b081fccd0fc3e010dc3ea2c38fffb.patch

That's something I find quite silly in github. Instead of putting a
[Download patch] link on the commit page they expect people to just
*know* that one can add .diff or .patch to the commit url to download it
as a diff. They have quite a few "hidden urls" like that...

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx