maria-discuss team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Reindl!

On Sep 29, Reindl Harald wrote:
> Am 29.09.2017 um 08:45 schrieb Sergei Golubchik:
> > Hi, Reindl!
> > 
> > I was able to repeat this error using your cmake command-line.
> > The culprit here is -DWITHOUT_DYNAMIC_PLUGINS=ON. The commit that
> > introduced the bug (43b262af55db507320b165bb0f9abf05b2f05a89)
> > makes
> > 
> >        SET_TARGET_PROPERTIES(mysqld PROPERTIES ENABLE_EXPORTS TRUE)
> > 
> > to be only done when dynamic plugins are enabled. But udf_example.so
> > is built even without dynamic plugins.
> > 
> > Incidentally, this is already fixed in the latest 10.2 code - your exact
> > cmake command-line completes successfully.
> > 
> > Sorry :(
> 
> so what now - i have planned deploayment of 10.2 with 10.2.9 and 
> expected it next week or so - expierience says now it's at least a month 
> - so please give me a unified diff which can be added to the rpm-sepc

Do you expect this diff to apply to 10.2.10 too?
The short one could be:

diff --git a/sql/CMakeLists.txt b/sql/CMakeLists.txt
--- a/sql/CMakeLists.txt
+++ b/sql/CMakeLists.txt
@@ -283,10 +283,10 @@ IF(APPLE)
   ENDIF()
 ENDIF()

-IF(NOT WITHOUT_DYNAMIC_PLUGINS)
   IF(NOT MSVC)
     SET_TARGET_PROPERTIES(mysqld PROPERTIES ENABLE_EXPORTS TRUE)
   ENDIF()
+IF(NOT WITHOUT_DYNAMIC_PLUGINS)
   GET_TARGET_PROPERTY(mysqld_link_flags mysqld LINK_FLAGS)
   IF(NOT mysqld_link_flags)
     SET(mysqld_link_flags)

It's not what we have in 10.2 now, but it's simple - just one line
moved - and it helps in your case.

> i thought there exists in the meantime a minimized build to avoid 
> happening that again and again - at least it was planned after the last 
> issues

Yes, but WITHOUT_DYNAMIC_PLUGINS is not part of it. We never build with
WITHOUT_DYNAMIC_PLUGINS. Did you consider making your build a bit less,
well, different?

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx