maria-discuss team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Guillaume!

On Nov 02, Guillaume Lefranc wrote:
> Hi Sergei!
> 
> There was no difference at all between the two generated files. The plot
> thickens....

That's imposible. If preprocessed files are identical, they either
compile both or fail both.

May be you had the modified source tree for some reason and now you
reverted that change (intentionally or not) and compilation should work.

Or may be it won't work and you generated these files incorrectly and
there is a difference, in fact.

I don't know. But if preprocessed files are identical, you cannot
possibly have one to compile and other to fail.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx

> -GL
> 
> Le mer. 1 nov. 2017 à 00:30, Sergei Golubchik <serg@xxxxxxxxxxx> a écrit :
> 
> > Hi, Guillaume!
> >
> > On Oct 31, Guillaume Lefranc wrote:
> > > Hi Sergei,
> > >
> > > I have no doubts about that, however, do you have any comments on the
> > > error above? It only happens when using those cmake options.
> > > The same is encountered when compiling on Mac OS X.
> > >
> > > I can't tell why it would fail on MY_WME which is literally everywhere.
> >
> > I have not the slightest idea how it could be possible.
> > I can only tell you how to find it out.
> >
> > This command:
> >
> >    make GenError && cd extra/mariabackup && make changed_page_bitmap.i
> >
> > repeat with this cmake config below (that fails to build) and with some
> > other config (that succeeds). Look at the generated file
> >
> >    CMakeFiles/mariabackup.dir/changed_page_bitmap.cc.i
> >
> > Grep it for MY_WME, see what's included, diff it from two builds, see
> > why one of them defines MY_WME and the other doesn't.
> >
> > And, when you solve it, please, do tell what it was :)
> >
> > > > > $ cmake . -DPLUGIN_MROONGA=NO -DPLUGIN_TOKUDB=NO -DPLUGIN_SPHINX=NO
> > > > > -DPLUGIN_ROCKSDB=NO
> > > > > $ make
> > > >
> > > > > This fails with the following errors:
> > > > > [ 98%] Building CXX object
> > > > > extra/mariabackup/CMakeFiles/mariabackup.dir/changed_page_bitmap.cc.o
> > > > > In file included from
> > > > > /home/tanj/mariadb-10.2/storage/innobase/include/univ.i:83:0,
> > > > >                  from
> > > > > /home/tanj/mariadb-10.2/storage/innobase/include/ut0rbt.h:29,
> > > > >                  from
> > > > > /home/tanj/mariadb-10.2/extra/mariabackup/changed_page_bitmap.h:28,
> > > > >                  from
> > > > > /home/tanj/mariadb-10.2/extra/mariabackup/changed_page_bitmap.cc:25:
> > > > > /home/tanj/mariadb-10.2/extra/mariabackup/common.h: In
> > > > > function‘size_t xb_read_full(File, uchar*, size_t)’:
> > > > > /home/tanj/mariadb-10.2/extra/mariabackup/common.h:162:45:
> > > > > error: ‘MY_WME’ was not declared in this scope
> > > > >    tbytes = my_read(fd, buf, len - tlen, MYF(MY_WME));
> > > > >                                              ^
> > > > > /home/tanj/mariadb-10.2/include/my_global.h:1025:24: note: in
> > > > > definition of macro ‘MYF’
> > > > >  #define MYF(v)  (myf) (v)
> > > > >                         ^