← Back to team overview

mudlet-makers team mailing list archive

Re: [Bug 1222338] Re: centerview() on a room ID that doesn't exist causes odd highlighting

 

Seems like you are asking about checking for a null pointer versus the
value 0. Nowadays I believe the check is equivalent (ie if (!a pointer of
0x0) and if (!0) will go into the same branch of logic). See here:
http://stackoverflow.com/questions/176989/do-you-use-null-or-0-zero-for-pointers-in-c


On Tue, Sep 24, 2013 at 3:51 PM, Stephen Lyons
<1222338@xxxxxxxxxxxxxxxxxx>wrote:

> It was stupidly late for me to be thinking about code!  But what was
> unclear to me is: whether - as part of the code used for
> TLuaInterpreter::centerview() where it calls TRoomDB::getRoom() and uses
> the return value as a boolean one as part of an if() condition.  In the
> case I was unsure about I wonder whether it is safe to an integer 'zero'
> value (where the roomID is NOT a valid room) when the getRoom() function
> is supposed to return a pointer to a TRoom class.  My uncertainty was
> not reduced when I tried to find out more using the Stack Overflow
> website.  It is quite possible that I have "grabbed the wrong end of the
> stick" as it were and my knowledge of C++ is not as good as I would hope
> (I'm coming from a C background) so please forgive me if I am in error
> here.
>
> --
> You received this bug notification because you are subscribed to Mudlet.
> https://bugs.launchpad.net/bugs/1222338
>
> Title:
>   centerview() on a room ID that doesn't exist causes odd highlighting
>
> Status in Mudlet the MUD client:
>   New
>
> Bug description:
>   Attached is a screenshot of the map with centerview() on a valid room,
>   and the next view of when centerview() is not on a valid room - some
>   rooms and exits get "selected".
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1222338/+subscriptions
>

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1222338

Title:
  centerview() on a room ID that doesn't exist causes odd highlighting

Status in Mudlet the MUD client:
  New

Bug description:
  Attached is a screenshot of the map with centerview() on a valid room,
  and the next view of when centerview() is not on a valid room - some
  rooms and exits get "selected".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1222338/+subscriptions


References