← Back to team overview

mudlet-makers team mailing list archive

[Bug 1193211] Re: JSON decoder errors aren't properly logged

 

https://github.com/Chris7/Mudlet2/commit/797265e243b0bf7c72ab040a808026d0cfaea06a

** Changed in: mudlet
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1193211

Title:
  JSON decoder errors aren't properly logged

Status in Mudlet the MUD client:
  Fix Committed

Bug description:
  I saw this in the errors view:

  [ERROR:] object:<JSON decoder error:> function:<json_to_value>
           <>

  With no JSON error attached. Looking at the code:

              string e;
              if( lua_isstring( L, 1 ) )
              {
                  e = "Lua error:";
                  e += lua_tostring( L, 1 );
              }
              QString _n = "JSON decoder error:";
              QString _f = "json_to_value";
              logError( e, _n, _f );

  It should be using -1 as the index for the top of the stack, because 1
  might not be the top (which seems to be the case in my error).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1193211/+subscriptions


References