← Back to team overview

mudlet-makers team mailing list archive

[Bug 1329948] Re: rightclicking the left aligned timestamp "frame" crashes the client

 

Got it! In TTextEdit::mousePressEvent() when the timestamps are enabled
the normal lines of text are offset to the right by 13 spaces (so the
time stamps can go at the start of the line) this means the character
x-coordinates used to manipulate text selections in the console have to
have 13 added to them to refer to the correct text - but if the mouse is
pressed in the time stamp area the coordinate will be less than zero
which causes a seg. fault (the time stamp bit of the the text lines is
NOT selectable).

The code for the left mouse button press correctly limits the x
coordinate to not less than zero but the boundary value checks have not
been repeated for the right mouse button press code.

The attached commit is for the current Source Forge Master but should
apply to pretty much any recent version.  Unfortunately I got my local
master branch out of step with my public one on GitHub and until I can
get them synced without losing other stuff locally I'm not sure I can
push this commit out to my public repository directly.

** Attachment added: "Patch against current release code"
   https://bugs.launchpad.net/mudlet/+bug/1329948/+attachment/4134632/+files/commit-ba69156

** Changed in: mudlet
   Importance: Undecided => Critical

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1329948

Title:
  rightclicking the left aligned timestamp "frame" crashes the client

Status in Mudlet the MUD client:
  Confirmed

Bug description:
  Rightclicking on the timestamp "frame" causes the client to crash on
  win7 x32/64 and Ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1329948/+subscriptions


References