mudlet-makers team mailing list archive

[Stephen Lyons <1095946@xxxxxxxxxxxxxxxxxx>]

This is caused by a missing else in dlgTriggerEditor::saveAlias() (in
around line 3639 of dlgTriggerEditor.cpp) which means that the grey
(disabled by ancestor) icon is used.  It is fixed in code put forward my
me and currently being checked over by Ahmed Charles in his GH
repository, branch "icons".

In essence the patch would be as follows, though there are other
proposed changes that would clash:

             if( pT->state() )
             {
                 if( old_name == "New Alias" )//|| old_name == "New Alias Group" )
                 {
                     QIcon _icon;
                     if( pT->isFolder() )
                     {
                         if( pT->ancestorsActive() )
                             _icon.addPixmap( QPixmap( QStringLiteral( ":/icons/folder-violet.png" ) ), QIcon::Normal, QIcon::Off );
                         else
                             _icon.addPixmap( QPixmap( QStringLiteral( ":/icons/folder-grey.png" ) ), QIcon::Normal, QIcon::Off );
                     }
                     else
                     {
                         if( pT->ancestorsActive() )
                            _icon.addPixmap( QPixmap( QStringLiteral( ":/icons/tag_checkbox_checked.png" ) ), QIcon::Normal, QIcon::Off );

+                        else
+                            _icon.addPixmap( QPixmap( QStringLiteral( ":/icons/tag_checkbox_checked_grey.png" ) ), QIcon::Normal, QIcon::Off
-                        _icon.addPixmap( QPixmap( QStringLiteral( ":/icons/tag_checkbox_checked_grey.png" ) ), QIcon::Normal, QIcon::Off );
);
                     }
                     pItem->setIcon( 0, _icon );
                     pItem->setText( 0, name );
                     pT->setIsActive( true );
                 }
                 else
                 {
                     pItem->setIcon( 0, icon);
                     pItem->setText( 0, name );
                 }
             }
             else
             {
                 QIcon iconError;
                 iconError.addPixmap( QPixmap( QStringLiteral( ":/icons/tools-report-bug.png" ) ), QIcon::Normal, QIcon::Off );
                 pItem->setIcon( 0, iconError );
                 pItem->setText( 0, name );
             }

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1095946

Title:
  Icon on newly-made aliases is monotone

Status in Mudlet the MUD client:
  In Progress

Bug description:
  When you create and hit 'Save' button on the alias that was just made,
  the icon that appears besides is monochrome - when the alias is
  enabled. Clicking on it causes it to go technicolor properly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1095946/+subscriptions