← Back to team overview

mudlet-makers team mailing list archive

[Bug 1413435] Re: Ghost exits left in the Exits dialog when a room is deleted

 

Determined that commit 94c5066613e97705a65ec215208609ef35a2f6e8 "Speed
up room deletion" uses a new TRoomDB::reverseExitMap to work out which
rooms have exits into a room being deleted.  This is supposed to short-
cut the need to iterating thought every exit for every room to find the
exit that leads to a room being deleted so they can be reset to -1 "no
exit".  Unfortunately NO ATTEMPT IS MADE TO MAINTAIN THE DATA IN
TRoomDB::reverseExitMap, except for when a room is added or removed.
The data is NOT saved (that would require a change in the map file
format!) and NOT regenerated when a map is loaded.  The consequence is
clear - rooms that had exits TO a room being deleted are not having the
exit cleared, and calling up the room exit dialog is just one place
where this WILL cause a crash.

I will look to fix the underlying issue to (re)generated this data on
loading and also make the dlgRoomExits class more robust.

As this causes a terminal crash on the current release 3.0 preview
(delta) I think it merits elevation to "Critical" status. 8-(

** Changed in: mudlet
   Importance: Medium => Critical

** Changed in: mudlet
       Status: Confirmed => Triaged

** Changed in: mudlet
     Assignee: (unassigned) => Stephen Lyons (slysven)

-- 
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1413435

Title:
  Ghost exits left in the Exits dialog when a room is deleted

Status in Mudlet the MUD client:
  Triaged

Bug description:
  "When I make a link between two rooms and then delete one of them the
  link from the existing room to the deleted room (it's ID) is
  remembered in "exits". To avoid problems with a connection to a non-
  existent room I want to remove it manually. To do this I need to
  right-click on the map, select "exits" and delete one of the IDs, but
  exactly when I click on "exits" Mudlet crashes :("

  Originally reported at:
  http://forums.mudlet.org/viewtopic.php?f=5&t=4695&p=22335#p22332

To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1413435/+subscriptions


Follow ups

References