← Back to team overview

mugle-dev team mailing list archive

[Bug 722966] Re: GameVersion version number should be an int

 

** Changed in: mugle
    Milestone: None => 0.1.1

-- 
You received this bug notification because you are a member of MUGLE
Developers, which is subscribed to MUGLE.
https://bugs.launchpad.net/bugs/722966

Title:
  GameVersion version number should be an int

Status in Melbourne University Game-based Learning Environment:
  Fix Committed

Bug description:
  Currently, the GameVersion class's primary key pKey is a String, which
  is emulating a composite key built from the Game ID (int) and version
  number (string). This is a bit messy, but we have decided to keep this
  weird string composite key.

  The bug is this: The "version number" part of the string is itself an
  arbitrary string. It should be an int. Thus, pKey is a string
  comprising two ints separated by a slash.

  GameVersion's version parameter should have type int. getVersion
  should return an int.

  The reason it was a string was to support version numbers such as
  "1.4.2". That is not the purpose of a primary key -- they should be
  sequential integers which developers have no control over (they simply
  increment each version). Outside the scope of this bug: add another
  field "version_string" which is a developer-customisable version
  number string, for display purposes only.