mythbuntu-bugs team mailing list archive

[Mario Limonciello <superm1@xxxxxxxxxx>]

** Changed in: lirc (Ubuntu)
       Status: Triaged => Fix Committed

-- 
/etc/init.d/lirc broken when both REMOTE and TRANSMITTER are defined
https://bugs.launchpad.net/bugs/475664
You received this bug notification because you are a member of Mythbuntu
Bug Team, which is subscribed to lirc in ubuntu.

Status in “lirc” package in Ubuntu: Fix Committed

Bug description:
Binary package hint: lirc

The patch is small..  I had to move the renaming of the TRANSMITTER_SOCKET variable into the if block that defines the default value.  This is the proper behavior anyway, since if the user has defined a value for TRANSMITTER_SOCKET we shouldn't be touching it.

--- /etc/init.d/lirc    2009-10-17 06:06:53.000000000 -0400
+++ lirc        2009-11-05 12:49:36.700779791 -0500
@@ -80,7 +80,6 @@
                #Now, if we ALSO have a remote defined, add some args
                #To make the second lircd connect
                if [ ! -z "$REMOTE_DEVICE" ] || [ ! -z "$REMOTE_DRIVER" ]; then
-                       TRANSMITTER_SOCKET="${TRANSMITTER_SOCKET}1"
                        TRANSMITTER_ARGS="$TRANSMITTER_ARGS --connect=localhost:8765 --pidfile=/var/run/lirc/lircd1.pid"
                fi
                TRANSMITTER_ARGS="--output=$TRANSMITTER_SOCKET $TRANSMITTER_ARGS"
@@ -129,6 +128,11 @@
 fi
 if [ -z "$TRANSMITTER_SOCKET" ]; then
        TRANSMITTER_SOCKET="/var/run/lirc/lircd"
+       #Now, if we ALSO have a remote defined,
+       #change the default transmitter socket
+       if [ ! -z "$REMOTE_DEVICE" ] || [ ! -z "$REMOTE_DRIVER" ]; then
+               TRANSMITTER_SOCKET="${TRANSMITTER_SOCKET}1"
+       fi
 fi

 case "$1" in