mythbuntu-bugs team mailing list archive
-
mythbuntu-bugs team
-
Mailing list archive
-
Message #03993
Re: [Bug 708643] Re: /etc/init/mythtv-backend needs to source /etc/default/mythtv-backend
On Thu, Jan 27, 2011 at 09:19, Brian J. Murrell <brian@xxxxxxxxxxxxxxx>wrote:
>
>
> That's a pain to have to do. Why should I have to interact with package
> installation when there is a solution to avoid it completely, 100% of
> the time?
>
>
The change was made because people were mistakingly making changes in
/etc/default/mythtv-backend that they would have expected to be benign and
having a difficult time debugging it. Upstart jobs are quite simple,
there's no need to add that complexity when the upstart job is the only
thing sourcing the file. The reason that files were placed in /etc/default
in the first place is two fold:
1) Administrators have difficult merging local changes to complex init
scripts with those in packaging updates
This is not the case with the mythtv job anymore.
2) Multiple files need to source files from /etc/default.
No other application or file needs to source this file.
> Well, I just had to merge it yet again.
>
>
Well that doesn't make much sense. The last change was in November.
------------------------------------------------------------
revno: 373
fixes bug(s): https://launchpad.net/bugs/542627
committer: Mario Limonciello
branch nick: mythtv-fixes
timestamp: Wed 2010-11-24 16:29:46 -0600
message:
Stop on runlevels [016] rather than on the start of shutdown job. (LP:
#542627)
> But I say again, if you just apply the patch I supplied nobody will
> every have to merge ever again. Doesn't this make more sense from a
> packaging and administration perspective?
>
>
Not when you consider how many people may have that file sitting around with
local changes to it that cause problems. You're not allowed to remove it in
a maintainer script if someone has made local changes, making the problem
worse.
> The solution I am proposing is completely benign to those that don't use
> it and is a net positive to those that do. Why are you resisting it?
> What harm is caused by applying it?
>
> --
> You received this bug notification because you are a member of Mythbuntu
> Bug Team, which is subscribed to Mythbuntu.
> https://bugs.launchpad.net/bugs/708643
>
> Title:
> /etc/init/mythtv-backend needs to source /etc/default/mythtv-backend
>
> Status in Mythbuntu, Ubuntu derivative focused upon MythTV:
> Won't Fix
>
> Bug description:
> I thought I had reported this once before but I could not find any
> sign of it. Perhaps I just discussed it in IRC or something.
>
> In any case, the backend initscript needs to source /etc/default
> /mythtv-backend as it did previously when it was an /etc/init.d/
> initscript.
>
> The reason is that some people might need to set some environment that
> will affect the backend process, such as, for example:
>
> # need to set the proxy for mythfilldatabase
> export http_proxy=http://proxy:3128/
>
> It's a simple one line change:
>
> --- /etc/init/mythtv-backend.conf.new 2010-12-30 19:00:10.000000000 -0500
> +++ /etc/init/mythtv-backend.conf 2010-11-17 07:29:58.000000000 -0500
> @@ -19,6 +19,7 @@
> end script
>
> script
> + . /etc/default/mythtv-backend
> test -f /etc/default/locale && . /etc/default/locale || true
> LANG=$LANG /usr/bin/mythbackend --logfile
> /var/log/mythtv/mythbackend.log --user mythtv
> end script
>
> In the case of people who have no need for it, the above change is
> benign, but for people who do need it, it's very useful, so there
> really should be no reason to resist it.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~mythbuntu-bugs
> Post to : mythbuntu-bugs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~mythbuntu-bugs
> More help : https://help.launchpad.net/ListHelp
>
--
Mario Limonciello
superm1@xxxxxxxxx
Follow ups
References