mythbuntu-bugs team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

The uploaded SRU includes the following new file, which is not covered
by the MRE and not explained in the changelog:

--- mythtv-0.25.0+fixes.20120410.1f5962a/debian/30-mythtv-sysctl.conf   1970-01-01 00:00:00.000000000 +0000
+++ mythtv-0.25.2+fixes.20120802.46cab93/debian/30-mythtv-sysctl.conf   2012-08-01 13:59:24.000000000 +0000
@@ -0,0 +1,5 @@
+# Increase the max allowed socket buffer for MythTV.
+#   See http://code.mythtv.org/trac/ticket/10414 for more context
+# Doesn't actually increase the default socket buffer so it shouldn't affect
+#   any other applications.
+net.core.rmem_max=1048576

Please explain why this is appropriate to include in an SRU (preferably
with a reupload that provides a link to an Ubuntu bug in the changelog).

--- mythtv-0.25.0+fixes.20120410.1f5962a/debian/mythtv-database.postinst        2011-12-08 16:10:15.000000000 +0000
+++ mythtv-0.25.2+fixes.20120802.46cab93/debian/mythtv-database.postinst        2012-08-01 13:59:24.000000000 +0000
@@ -112,7 +112,7 @@
     #and mysql binding checks
     if [ -f "${MYSQLCONFIG}" ]; then
         db_get mythtv/public_bind
-        if [ $RET = true ]; then
+        if [ -n "$RET" ] && [ $RET = true ]; then
             NEWIP=`ifconfig | grep "inet addr:" | grep --invert-match 127.0.0.1 | sed ' s/inet addr://g; s/^[ \t]*//;s/[ \t]*$//; q;' | awk '{print $1}'`
             sed -i -e 's/^#bind/bind/' ${MYSQLCONFIG}
         else

This would have been more succinctly written

   if [ "$RET" = true ]; then

> +  * Update apport hook for python3 (LP: #1013171)

python3 is not used for apport in 12.04, and there's no reason to
include such a change in an SRU - this is all risk and no benefit.
Please drop this change.

The rest of the changes to debian/ seem fine, and the changes outside of
debian/ are of course covered by the MRE.  Please reupload with the
aforementioned changes.  Rejecting from the queue for now.

** Bug watch added: code.mythtv.org/trac/ #10414
   http://code.mythtv.org/trac/ticket/10414

** Changed in: mythtv (Ubuntu Precise)
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Mythbuntu
Bug Team, which is subscribed to mythtv in Ubuntu.
https://bugs.launchpad.net/bugs/1029522

Title:
  Newer version of MythTV fixing some major bugs needs an SRU

Status in “mythtv” package in Ubuntu:
  Fix Released
Status in “mythtv” source package in Precise:
  Triaged

Bug description:
  For each MythTV release, upstream keeps a "fixes" branch where they
  commit fixes (rather than features) of bugs found in that release.
  This has quite a few fixes for some major bugs found in the version
  released with 12.04 and be uploaded as an SRU.

  [IMPACT]

   * Minor issues aside, some of the major issues in the 12.04 release are
      * Running mythfilldatabase takes much longer (hours instead of minutes) to run due to MySQL 5.5 using the innodb engine by default. ( https://bugs.launchpad.net/ubuntu/+source/mythtv/+bug/997367 )
      * One of the most popular tuner cards failed recording when run in Digital Cable mode ( http://code.mythtv.org/trac/ticket/10712 )

   * Mythbuntu is doing LTS only releases, thus this needs to be fixed
  in the point release ISOs.

  [TESTCASE]

   * Install a MythTV backend, sign up for an account at
  http://www.schedulesdirect.org/, configure mythtv-backend, run
  mythfilldatabase --dd-grab-all. This will take a few hours to run and
  disk IO will be high.

  [Regression Potential]

   * The MythTV set of packages are isolated in that nothing is built
  against them. There should be no regression as the fixes are on MythTV
  itself.

   * The Mythbuntu team provides a PPA with builds of MythTV where these
  fixes have been tested on 12.04. We've not heard any negative feedback
  on these fixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mythtv/+bug/1029522/+subscriptions