← Back to team overview

mythbuntu-bugs team mailing list archive

[Bug 1038371] Re: disabling in-kernel support should be optional

 

This patch is syntactically incorrect, which leads me to question how
much it's been tested :-)

+       if [ -d /sys/class/rc -a "$DISABLE_KERNEL_SUPPORT" = "true"];
then

There's a missing space before the ] there.  Also, I would generally
advise avoiding the use of -a and -o inside [ ] as the rules are arcane
and not as portable as you might hope.  So I would write this as:

  if [ -d /sys/class/rc ] && [ "$DISABLE_KERNEL_SUPPORT" = true ]; then

Also, all changes need to be made in the development release (currently
quantal) first.  If they meet the criteria in
https://wiki.ubuntu.com/StableReleaseUpdates, you can then work through
those to apply the patch to precise.

-- 
You received this bug notification because you are a member of Mythbuntu
Bug Team, which is subscribed to lirc in Ubuntu.
https://bugs.launchpad.net/bugs/1038371

Title:
  disabling in-kernel support should be optional

Status in “lirc” package in Ubuntu:
  New

Bug description:
  I have an Antec case with an iMon knob device, as well as a serial
  port IR receiver.  The knob produces events, so I don't need lirc for
  it.  I also use the imon device for lcdproc.  I run lirc, solely to
  communicate with the serial IR device.   The current lirc init script
  attempts to modify the imon device in /sys/class/rc/rc0/protocols.
  This is unnecessary, as I don't intend to use that device with lirc,
  and furthermore, for reasons unknown, it occasionally causes the
  computer to fail to shut down.  I don't particularly care why echoing
  "none" to /sys/class/rc/rc0/protocols hangs occasionally, because it
  isn't an operation that needs to be done at all on my system.  I can
  edit the init script to prevent this happening, but I'd much prefer
  for there to be an option in /etc/lirc/hardware.conf to prevent in-
  kernel support from being disabled while i run lirc, and re-enabled
  when I stop it.

  Attached is a patch with a suggested method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lirc/+bug/1038371/+subscriptions


References