← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~aluria/hw-health-charm/+git/hw-health-charm:unittests-engrot6 into hw-health-charm:master

 

Code has been rewritten following Joel's suggestions on another couple of MPs that I have now deleted. Useless comments (or commented code) has been removed and nagios_plugin3.py from nrpe-charm is used to return a nagios check status.

tox.ini calls a script in src/tests/ that downloads nagios_plugin3.py from nrpe-charm repo and copies it into {toxinidir}/py3/lib/python3*/ for unittesting purposes.

Charm has been tested in Huawei equipment (sas2ircu) and will also be tested tomorrow in Supermicro equipment (sas3ircu).

TODO: I'll review the README with the action plan and push code to cs:~nagios-charmers/hw-health as soon as I get it reviewed.

Thank you.
-- 
https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/361785
Your team Nagios Charm developers is requested to review the proposed merge of ~aluria/hw-health-charm/+git/hw-health-charm:unittests-engrot6 into hw-health-charm:master.


References