← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~alephnull-b/thruk-master-charm:bionic-support into thruk-master-charm:master

 

> > looks good, but I think it'd be cleaner to have two separate commits, as the
> > issues fixed are conceptually separate
> 
> While I agree in concept, two lines of change splitting into two one line
> changes seems a bit much IMO.

Oh and if a bug is closed it should be linked to the review so it updates when accepted and merged.
-- 
https://code.launchpad.net/~alephnull-b/thruk-master-charm/+git/thruk-master-charm/+merge/362027
Your team Nagios Charm developers is subscribed to branch thruk-master-charm:master.


References