← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~woutervb/nagios-charm:reactive into nagios-charm:master

 

Review: Disapprove

I think a total rebuild of nagios-charm to reactive should be merged into a nagios-layer repo (created via "charm-create" repo, which uses "template-python-pytest" repo). This is too big of a change to merge it into master. First, because the charm would become a layer that needs to be rebuilt, but also because this version is not supposed to replicate the legacy code, but to enhance it (ie. by creating smaller nagios configs included in the main nagios.cfg file).
-- 
https://code.launchpad.net/~woutervb/nagios-charm/+git/nagios-charm/+merge/362668
Your team Nagios Charm developers is subscribed to branch nagios-charm:master.


References