nagios-charmers team mailing list archive
-
nagios-charmers team
-
Mailing list archive
-
Message #00268
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
Xav Paice has proposed merging ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master.
Requested reviews:
Nagios Charm developers (nagios-charmers)
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363450
--
Your team Nagios Charm developers is requested to review the proposed merge of ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master.
diff --git a/src/tests/unit/test_cron_mdadm.py b/src/tests/unit/test_cron_mdadm.py
index dffd65b..016745e 100644
--- a/src/tests/unit/test_cron_mdadm.py
+++ b/src/tests/unit/test_cron_mdadm.py
@@ -29,10 +29,13 @@ class TestCronMdadm(unittest.TestCase):
@mock.patch('os.path.exists')
@mock.patch('subprocess.Popen')
- def test_get_devices_mdadm_exception(self, mdadm_details, path_exists):
+ @mock.patch('sys.exit')
+ def test_get_devices_mdadm_exception(self, mock_exit, mdadm_details,
+ path_exists):
path_exists.return_value = True
mdadm_details.side_effect = subprocess.CalledProcessError(
1, 'unittest')
+ mock_exit.return_value = 0
self.assertEqual(cron_mdadm.get_devices(), set())
@mock.patch('cron_mdadm.generate_output')
Follow ups
-
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-05-23
-
Re: [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-05-23
-
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Xav Paice, 2019-05-23
-
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Xav Paice, 2019-05-23
-
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-05-09
-
Re: [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-05-09
-
[Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: David O Neill, 2019-05-09
-
Re: [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-04-01
-
Re: [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Canonical IS Mergebot, 2019-04-01
-
Re: [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master
From: Alvaro Uría, 2019-03-18