← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

 

Review: Resubmit

Thanks for the detailed review - I've address (most) of the comments.  I've not added all the docstrings requested as it's hard to know where to draw the line between changes relevant to this branch and changes that just make the overall code better - I suggest raising bugs for things outside the scope of this change, which is about adding IPMI support to the charm.
-- 
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.


References