nagios-charmers team mailing list archive

[Paul Goins <paul.goins@xxxxxxxxxxxxx>]

Review: Abstain

Provided some feedback.

Diff comments:

> diff --git a/.gitignore b/.gitignore
> index 8f6789a..3fbd340 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -17,3 +17,5 @@ __pycache__/
>  
>  # version data
>  src/repo-info
> +
> +tools.zip

Unintentional change?

> diff --git a/src/lib/utils/hwdiscovery.py b/src/lib/utils/hwdiscovery.py
> index c144fa4..480fea2 100644
> --- a/src/lib/utils/hwdiscovery.py
> +++ b/src/lib/utils/hwdiscovery.py
> @@ -39,8 +39,6 @@ def get_tools():
>          tools.add('hpe')  # ['hponcfg', 'ilorest']
>      elif hw_vendor == 'HP':
>          tools.add('hp')  # ['hponcfg', 'hp-health', 'hpssacli']
> -    elif hw_vendor == 'Supermicro':
> -        tools.add('sas3ircu')

These lines were added as part of this review: https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/361785.  It might be okay, but I'm curious as to what Alvaro thinks.  I don't know why these lines were added in here to begin with; perhaps there is a reason we don't see here...

>  
>      # SW RAID?
>      if _supports_mdadm():


-- 
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/364345
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.