nagios-charmers team mailing list archive

[Alvaro Uría <alvaro.uria@xxxxxxxxxxxxx>]

* classes.py lgtm
* Since flake8 max-lines=120, we should try to honor it on all files (maybe excessive nesting from the time I used max-lines=80)
* tox.ini complexity needs to be reduced from 20 to 10
* unit tests should be rewritten (probably on a different MP) using pytest, since we have functional tests that also use pytest. Aim is to avoid having 2 different testing frameworks (unittest and pytest) within the same project.
-- 
https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364694
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.