nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~aieri/hw-health-charm:oo-rewrite-prep1 into hw-health-charm:oo-rewrite-integration

To: mp+364750@xxxxxxxxxxxxxxxxxx
From: Alvaro Uría <alvaro.uria@xxxxxxxxxxxxx>
Date: Wed, 20 Mar 2019 07:43:42 -0000
In-reply-to: <155300438117.20052.15538846689845033981.launchpad@ackee.canonical.com>
Reply-to: mp+364750@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

lgtm. I still have doubts about the use of @hook that has also been suggested by stubs in the past. I've always thought the reactive framework approach is to always use states (@when, when_not) and hookenv.hook_name() when a specific hook needs to run some code.
-- 
https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364750
Your team Nagios Charm developers is subscribed to branch hw-health-charm:oo-rewrite-integration.

References

[Merge] ~aieri/hw-health-charm:oo-rewrite-prep1 into hw-health-charm:oo-rewrite-integration
From: Andrea Ieri, 2019-03-19