nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~aieri/hw-health-charm:oo-rewrite-functest into hw-health-charm:oo-rewrite-integration

To: mp+364758@xxxxxxxxxxxxxxxxxx
From: Alvaro Uría <alvaro.uria@xxxxxxxxxxxxx>
Date: Wed, 20 Mar 2019 08:10:49 -0000
In-reply-to: <155300570073.27013.13598538588617114092.launchpad@ackee.canonical.com>
Reply-to: mp+364758@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

lgtm. Please take a look to this MP[1] to consider addressing the use of deprecated charmtools variables in favor of the new ones. If so, CHARM_BUILD_DIR needs to be used in tox.ini and function/test_deploy.py as in [2].

1. https://code.launchpad.net/~aluria/template-python-pytest/+git/template-python-pytest/+merge/364040
2. https://code.launchpad.net/~aluria/grafana-charm/+git/grafana-charm-1/+merge/364044
-- 
https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364758
Your team Nagios Charm developers is subscribed to branch hw-health-charm:oo-rewrite-integration.

References

[Merge] ~aieri/hw-health-charm:oo-rewrite-functest into hw-health-charm:oo-rewrite-integration
From: Andrea Ieri, 2019-03-19