← Back to team overview

nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~aieri/hw-health-charm:oo-rewrite-functest-removal into hw-health-charm:oo-rewrite-integration

To: mp+364761@xxxxxxxxxxxxxxxxxx
From: Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>
Date: Thu, 21 Mar 2019 07:27:47 -0000
In-reply-to: <155300584007.28125.13917716628447590020.launchpad@ackee.canonical.com>
Reply-to: mp+364761@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good, including aluria's comment that a timeout is needed in the block_until call.
-- 
https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/364761
Your team Nagios Charm developers is subscribed to branch hw-health-charm:oo-rewrite-integration.

References

[Merge] ~aieri/hw-health-charm:oo-rewrite-functest-removal into hw-health-charm:oo-rewrite-integration
From: Andrea Ieri, 2019-03-19