nagios-charmers team mailing list archive

[Alvaro Uría <alvaro.uria@xxxxxxxxxxxxx>]

* File in /etc/sudoers.d can't have a "~" or "." (renamed sudoers file), and added a few more commands allowed to be run as root.
* check_ipmi_sensors Perl script takes ~20s to run. I initially tried to use os.fork on a wrapper script, but check_nrpe continued waiting until the child exited (not only the parent, as on the CLI tests)
* for the reason above, I've added the wrapper as a cronjob (it allows args via "ipmi_check_options" config parameter). Since the cronjob allows parameters passed via juju config, we should think of sanitizing the input (it now allows ";" and other chars). At least, the cronjob runs as "nagios" user instead of "root".
* "_install_cronjob_script" and "_remove_cronjob_script" have been moved from the VendorTools class to its parent (Tools), so it can be used by the Ipmi class
* functional tests have been fixed to check for the cronjob script (and its removal) for the tools.Ipmi

Both unit and functional tests pass, and tests in a staging env (baremetal) were successful.
-- 
https://code.launchpad.net/~aluria/hw-health-charm/+git/hw-health-charm/+merge/365060
Your team Nagios Charm developers is requested to review the proposed merge of ~aluria/hw-health-charm/+git/hw-health-charm:fix-check-ipmi into hw-health-charm:master.