← Back to team overview

nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master

To: Xav Paice <xav.paice@xxxxxxxxxxxxx>
From: Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>
Date: Mon, 24 Jun 2019 08:09:01 -0000
In-reply-to: <156135831308.28971.15202854855917930874.codereview@gac.canonical.com>
Reply-to: mp+369224@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Sure. Personally I'd have kept sel_output as it was though, and this would be a single line patch 'mock_subprocess.return_value = sel_output.encode()'
-- 
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/369224
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.

References

Re: [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master
From: Canonical IS Mergebot, 2019-06-24