← Back to team overview

nagios-charmers team mailing list archive

[Merge] ~peter-sabaini/hw-health-charm:sas2ircu-allow-optimal-state into hw-health-charm:master

 

Peter Sabaini has proposed merging ~peter-sabaini/hw-health-charm:sas2ircu-allow-optimal-state into hw-health-charm:master.

Requested reviews:
  Nagios Charm developers (nagios-charmers)

For more details, see:
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/377999
-- 
Your team Nagios Charm developers is requested to review the proposed merge of ~peter-sabaini/hw-health-charm:sas2ircu-allow-optimal-state into hw-health-charm:master.
diff --git a/src/files/sas2ircu/check_sas2ircu.py b/src/files/sas2ircu/check_sas2ircu.py
index b22c380..7a4c861 100755
--- a/src/files/sas2ircu/check_sas2ircu.py
+++ b/src/files/sas2ircu/check_sas2ircu.py
@@ -34,7 +34,7 @@ def parse_output():
                 tmpdev = devices.get(device[2], [])
                 tmpdev.append('{}:{}'.format(device[0], device[1]))
                 devices[device[2]] = tmpdev
-                if 'Ready' not in device:
+                if not ('Ready' in device or 'Optimal' in device):
                     critical = True
                 device = []
 

Follow ups