nagios-charmers team mailing list archive

[Paul Goins <paul.goins@xxxxxxxxxxxxx>]

Review: Needs Fixing

I think this basically works.

Arguably I'd suggest simply removing the lines and adding them back in in the future if support is ever properly added, so as to remove cruft.  It depends on how likely we think that support will be added in the future.

It might be worth adding a comment to the code with an explanation, but at the same time, "git blame" can be used to find the commit that these were commented in, and the commit message can provide this explanation.

However, I would strongly suggest that we mention lp#1855095 either in the commit message or in a comment, as that won't be readily viewable via git after this gets merged.
-- 
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/379431
Your team Nagios Charm developers is subscribed to branch hw-health-charm:master.