← Back to team overview

nagios-charmers team mailing list archive

Re: [Merge] ~szeestraten/charm-nagios:bug/1864968 into charm-nagios:master

 

Thanks for the review Xav!

I prepended `_admin` and added comment in description to clarify it is for the default admin contact.

I considered adding similar config options for the pagerduty, but unfortunately it seems that the config option name `pagerduty_notification_levels` was chosen for the `service_notification_options` which breaks the naming convention and changing it for existing deployments is probably not the scope for this bug/patch.

Also commented that the notification_commands is for changing or adding custom notification plugins which is the intended use case for those commands.

-- 
https://code.launchpad.net/~szeestraten/charm-nagios/+git/nagios-charm/+merge/379943
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.


References