nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~aieri/charm-nagios:bug/1864192 into charm-nagios:master

To: mp+386291@xxxxxxxxxxxxxxxxxx
From: Alvaro Uria <alvaro.uria@xxxxxxxxxxxxx>
Date: Fri, 26 Jun 2020 14:06:01 -0000
In-reply-to: <159295142622.15692.8217720478123546480.launchpad@ackee.canonical.com>
Reply-to: mp+386291@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

* get_local_ingress_address comes from common.py [0]
* it is already used in -joined as mentioned
* it is now used in -changed
* fallbacks to [1]. However, I think [2] should be used. There seems to be a typo "private_address" vs "private-address". It is not likely to be hit because that's pre-Juju 2.3, but should be fixed (the previous func [ingress_address] removed in this MP uses "private-address" correctly)

Once that is fixed, it is +1 from me, thank you.

0. https://git.launchpad.net/~aieri/charm-nagios/tree/hooks/common.py?h=bug/1864192#n47
1. hostname = unit_get('private_address')
2. https://github.com/juju/charm-helpers/blob/master/charmhelpers/core/hookenv.py#L860
-- 
https://code.launchpad.net/~aieri/charm-nagios/+git/nagios-charm/+merge/386291
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.