← Back to team overview

nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~aieri/charm-nagios:bug/1864192-rebase into charm-nagios:master

To: mp+387312@xxxxxxxxxxxxxxxxxx
From: Alvaro Uria <alvaro.uria@xxxxxxxxxxxxx>
Date: Wed, 15 Jul 2020 10:10:09 -0000
In-reply-to: <159464978628.14101.9530619535524586856.launchpad@ackee.canonical.com>
Reply-to: mp+387312@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Change lgtm. However, there is no other way to test it than a manual deployment. If unit tests don't exist, I think we should at least convert amulet tests into Zaza tests.

Manual testing looks good, though. +1.
-- 
https://code.launchpad.net/~aieri/charm-nagios/+git/nagios-charm/+merge/387312
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.

References

[Merge] ~aieri/charm-nagios:bug/1864192-rebase into charm-nagios:master
From: Andrea Ieri, 2020-07-13