← Back to team overview

nagios-charmers team mailing list archive

Thread
Date

Re: [Merge] ~xavpaice/charm-nagios:makefile-20.08 into charm-nagios:master

To: Xav Paice <xav.paice@xxxxxxxxxxxxx>
From: Drew Freiberger <drew.freiberger@xxxxxxxxxxxxx>
Date: Mon, 03 Aug 2020 23:14:00 -0000
In-reply-to: <159649593345.30348.4929925080036964766.launchpad@ackee.canonical.com>
Reply-to: mp+388625@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM. also pulled and tested lint/unit and validated that functional testing starts up.  saw the data dir got removed from .gitignore, but this directory is not used by testing or the charm, so okay to remove.
-- 
https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/388625
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.

References

[Merge] ~xavpaice/charm-nagios:makefile-20.08 into charm-nagios:master
From: Xav Paice, 2020-08-03